Revert "Fix memory reservation accounting problem about InMemoryHashAggregationBuilder inside SpillableHashAggregationBuilder."#21133
Merged
vermapratyush merged 2 commits intomasterfrom Oct 12, 2023
Conversation
vermapratyush
requested review from
hantangwangd,
mbasmanova,
pgupta2,
shrinidhijoshi and
tdcmeehan
Contributor
Contributor
|
@vermapratyush Pratyush, would you open a GitHub issue and add a stack trace for "We are seeing assertion failure in Presto-On-Spark and has been blocking internal release." and reference that GitHub issue here? |
mbasmanova
approved these changes
Oct 12, 2023
tdcmeehan
approved these changes
Oct 12, 2023
Member
Author
|
Issue is being tracked here: #21134 |
vermapratyush
deleted the
revert-20360-spillable_aggregation_memory_accounting
branch
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing assertion failure in Presto-On-Spark and has been blocking internal release.
Meanwhile, I am working on reproducing the issue and a test case to support the case.
Reverts #20360
Tracking issue: #21134