Skip to content

Disable timestamp with time zone type for ddl #21096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Oct 26, 2023
Merged

Disable timestamp with time zone type for ddl #21096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions presto-iceberg/src/main/java/com/facebook/presto/iceberg/ColumnIdentity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ public static ColumnIdentity createColumnIdentity(Types.NestedField column)
String name = column.name();
org.apache.iceberg.types.Type fieldType = column.type();

if (fieldType.equals(Types.TimestampType.withZone())) {
throw new UnsupportedOperationException(format("Iceberg column type %s is not supported", fieldType));
}

if (!fieldType.isNestedType()) {
return new ColumnIdentity(id, name, PRIMITIVE, ImmutableList.of());
}
Expand Down
9 changes: 8 additions & 1 deletion presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,9 +348,16 @@ public void addColumn(ConnectorSession session, ConnectorTableHandle tableHandle
if (!column.isNullable()) {
throw new PrestoException(NOT_SUPPORTED, "This connector does not support add column with non null");
}

org.apache.iceberg.types.Type columnType = toIcebergType(column.getType());

if (columnType.equals(Types.TimestampType.withZone())) {
throw new PrestoException(NOT_SUPPORTED, format("Iceberg column type %s is not supported", columnType));
}

IcebergTableHandle handle = (IcebergTableHandle) tableHandle;
Table icebergTable = getIcebergTable(session, handle.getSchemaTableName());
icebergTable.updateSchema().addColumn(column.getName(), toIcebergType(column.getType()), column.getComment()).commit();
icebergTable.updateSchema().addColumn(column.getName(), columnType, column.getComment()).commit();
}

@Override
Expand Down
9 changes: 9 additions & 0 deletions ...to-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedSmokeTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,15 @@ public void testTimestamp()
dropTable(getSession(), "test_timestamp");
}

@Test
public void testTimestampWithTimeZone()
{
assertQueryFails("CREATE TABLE test_timestamp_with_timezone (x timestamp with time zone)", "Iceberg column type timestamptz is not supported");
assertUpdate("CREATE TABLE test_timestamp_with_timezone (x timestamp)");
assertQueryFails("ALTER TABLE test_timestamp_with_timezone ADD COLUMN y timestamp with time zone", "Iceberg column type timestamptz is not supported");
dropTable(getSession(), "test_timestamp_with_timezone");
}

@Test
@Override
public void testDescribeTable()
Expand Down