Add session property to set input table matching threshold#21063
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Oct 12, 2023
Merged
Add session property to set input table matching threshold#21063feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu merged 1 commit intoprestodb:masterfrom
Conversation
75915c0 to
3a7875c
Compare
pranjalssh
approved these changes
Oct 10, 2023
3a7875c to
ade5956
Compare
mlyublena
approved these changes
Oct 10, 2023
ade5956 to
ce099ca
Compare
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add session property to set the threshold for input table stats matching in HBO
Motivation and Context
In HBO, when we get statistics from history runs, we are to compare the input table statistics in history runs with the input table statistics in current runs. If the difference is larger than a threshold, HBO estimates will not be used.
However, in debug, I found that it's hard to debug and tune this threshold. Currently it's set in config and needs to restart the coordinator to make changes. This PR is to add a session property for it, it's mainly for debugging/tuning purpose and hidden from user.
Impact
Make HBO debug and tune easier.
Test Plan
Existing unit tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.