Skip to content

Add session property to set input table matching threshold#21063

Merged
feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu:hbo_set_thd
Oct 12, 2023
Merged

Add session property to set input table matching threshold#21063
feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu:hbo_set_thd

Conversation

@feilong-liu
Copy link
Contributor

@feilong-liu feilong-liu commented Oct 6, 2023

Description

Add session property to set the threshold for input table stats matching in HBO

Motivation and Context

In HBO, when we get statistics from history runs, we are to compare the input table statistics in history runs with the input table statistics in current runs. If the difference is larger than a threshold, HBO estimates will not be used.

However, in debug, I found that it's hard to debug and tune this threshold. Currently it's set in config and needs to restart the coordinator to make changes. This PR is to add a session property for it, it's mainly for debugging/tuning purpose and hidden from user.

Impact

Make HBO debug and tune easier.

Test Plan

Existing unit tests

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add a session property `history_input_table_statistics_matching_threshold` to set the threshold for input statistics match in HBO.

@feilong-liu feilong-liu requested a review from a team as a code owner October 6, 2023 19:14
@feilong-liu feilong-liu requested a review from presto-oss October 6, 2023 19:14
@feilong-liu feilong-liu marked this pull request as draft October 6, 2023 19:14
@feilong-liu feilong-liu marked this pull request as ready for review October 6, 2023 22:50
@feilong-liu feilong-liu merged commit aa39d9c into prestodb:master Oct 12, 2023
@feilong-liu feilong-liu deleted the hbo_set_thd branch October 12, 2023 03:11
@wanglinsong wanglinsong mentioned this pull request Dec 8, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants