[pinot connector] Fix pinot single quote literal push down issue#21020
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Oct 9, 2023
Merged
Conversation
walterddr
approved these changes
Oct 3, 2023
tdcmeehan
approved these changes
Oct 3, 2023
ajaygeorge
approved these changes
Oct 4, 2023
Contributor
|
A small nit wrt commit message. |
Contributor
Author
thanks! done |
Contributor
Author
|
Hi, just checking if there is anything else needs to change. Thanks a lot for taking the time to review and approve it! |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When pushing down literal expression to pinot, single quote is not escaped.
Fix the issue by replacing single quote to two single quotes in a query.
Test Plan
Unit test with predicate
Release Notes
Please follow release notes guidelines and fill in the release notes below.