Revert "Enhance join reordering to work with non-simple equi-join clauses"#20943
Merged
ajaygeorge merged 1 commit intoprestodb:masterfrom Sep 22, 2023
Merged
Revert "Enhance join reordering to work with non-simple equi-join clauses"#20943ajaygeorge merged 1 commit intoprestodb:masterfrom
ajaygeorge merged 1 commit intoprestodb:masterfrom
Conversation
…uses" This reverts commit 009c06b.
6 tasks
feilong-liu
approved these changes
Sep 22, 2023
Contributor
|
@aaneja Please remember to add a test case surfacing the bug when you add a fix for this. (ideally as a safety net even before the fix) |
ajaygeorge
approved these changes
Sep 22, 2023
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 009c06b. from #20413
There is a subtle bug handling ProjectNodes between Join nodes that only do variable renames.
Reverting for now, while I figure out a better solution