Skip to content

[native] Add doc link to prestissimo page on develop ToC#20792

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
czentgr:cz_add_doc_link
Sep 8, 2023
Merged

[native] Add doc link to prestissimo page on develop ToC#20792
tdcmeehan merged 1 commit intoprestodb:masterfrom
czentgr:cz_add_doc_link

Conversation

@czentgr
Copy link
Contributor

@czentgr czentgr commented Sep 7, 2023

This PR adds the link of the prestissimo page to the develop page ToC that was missing.

Description

Adding a simple link on the develop page to the prestissimo page.

Motivation and Context

A user can not browse via links to the prestissimo page. Instead, the link has to be given directly.

Impact

A user can now browse to the prestissimo documentation page in the develop section.

Test Plan

None.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

This PR adds the link of the prestissimo page to the
develop page ToC that was missing.
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Built locally, link displays on the Developer Guide and selecting the link displays the Presto Native - Prestissimo page.

@czentgr czentgr added the docs label Sep 7, 2023
@czentgr
Copy link
Contributor Author

czentgr commented Sep 7, 2023

LGTM! (docs)

Built locally, link displays on the Developer Guide and selecting the link displays the Presto Native - Prestissimo page.

@steveburnett thank you for the review!

@czentgr czentgr marked this pull request as ready for review September 8, 2023 00:50
@czentgr czentgr requested a review from a team as a code owner September 8, 2023 00:50
@czentgr czentgr requested a review from presto-oss September 8, 2023 00:50
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Codenotify: Notifying subscribers in CODENOTIFY files for diff 13b2f5c...e8053ed.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/develop.rst

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@tdcmeehan tdcmeehan merged commit b042805 into prestodb:master Sep 8, 2023
@mbasmanova
Copy link
Contributor

@czentgr For some reason, I still don't see this doc in https://prestodb.io/docs/current/develop.html What else is missing?

CC: @Yuhta @pedroerp @tdcmeehan

@tdcmeehan
Copy link
Contributor

This will be added when the next release is finished (next few days)

@mbasmanova
Copy link
Contributor

@tdcmeehan Tim, thank you for clarifying. What's the usual delay between adding docs and seeing them published?

@tdcmeehan
Copy link
Contributor

We publish docs for every major release, which are now being cut roughly every 2 months.

@mbasmanova
Copy link
Contributor

@tdcmeehan Tim, thank you for clarifying. Do you think it would be helpful to publish "in-progress" version of the documentation as 2 months is a rather long time.

@tdcmeehan
Copy link
Contributor

We could add an unstable documentation page, as I believe other projects do. This would be for the last edge release or whatever is on trunk.

CC: @wanglinsong

@mbasmanova
Copy link
Contributor

We could add an unstable documentation page

That would be very helpful. Thanks.

@czentgr czentgr deleted the cz_add_doc_link branch July 31, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants