[WIP] Improve like performance#20790
Closed
jaystarshot wants to merge 2 commits intoprestodb:masterfrom
Closed
Conversation
Summary: Improve performance of LIKE matchers Subscribers: O4263 subscribe to presto changes JIRA Issues: PRESTO-5875 Differential Revision: https://code.uberinternal.com/D11139863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked changes change1 , change2 Microbenchmark was good, but did not show any production benefit. Some operations like Array.fill() etc were slower in NFA matching, suggesting that the micro benchmark was not accurate.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: