Skip to content

[WIP] Improve like performance#20790

Closed
jaystarshot wants to merge 2 commits intoprestodb:masterfrom
jaystarshot:improve-like-performance
Closed

[WIP] Improve like performance#20790
jaystarshot wants to merge 2 commits intoprestodb:masterfrom
jaystarshot:improve-like-performance

Conversation

@jaystarshot
Copy link
Member

@jaystarshot jaystarshot commented Sep 6, 2023

Description

Cherry-picked changes change1 , change2 Microbenchmark was good, but did not show any production benefit. Some operations like Array.fill() etc were slower in NFA matching, suggesting that the micro benchmark was not accurate.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

Summary: Improve performance of LIKE matchers

Subscribers: O4263 subscribe to presto changes

JIRA Issues: PRESTO-5875

Differential Revision: https://code.uberinternal.com/D11139863
@jaystarshot jaystarshot closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant