[native] Remove inheritence relationship between AsyncDataCache and MemoryAllo…#20372
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Jul 26, 2023
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47536273 |
tanjialiang
force-pushed
the
export-D47536273
branch
from
865dd74 to
bd76141
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47536273 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Jul 24, 2023
facebookincubator#5503) Summary: X-link: prestodb/presto#20372 Removing the relationship of AsyncDataCache inheritance from MemoryAllocator. Now they are depending on each other with registration mechanism. Related tests are refactored to be consistent with the new change. Pull Request resolved: facebookincubator#5503 Reviewed By: xiaoxmeng Differential Revision: D47536273 Pulled By: tanjialiang fbshipit-source-id: 9a02e8dc5e1f05a00d4cd7e2828fdd5e8648669e
tanjialiang
force-pushed
the
export-D47536273
branch
from
bd76141 to
2252793
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47536273 |
xiaoxmeng
reviewed
Jul 25, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@tanjialiang LGTM. Thanks for the work!
Contributor
There was a problem hiding this comment.
PRESTO_SHUTDOWN_LOG(INFO) << "Shutdown AsyncDataCache";
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Jul 25, 2023
#5503) Summary: X-link: prestodb/presto#20372 Removing the relationship of AsyncDataCache inheritance from MemoryAllocator. Now they are depending on each other with registration mechanism. Related tests are refactored to be consistent with the new change. Pull Request resolved: #5503 Reviewed By: xiaoxmeng Differential Revision: D47536273 Pulled By: tanjialiang fbshipit-source-id: 8a763533a489473eb8c88d768dc4e65e5b9c2e7a
tanjialiang
force-pushed
the
export-D47536273
branch
from
2252793 to
bf745b6
Compare
tanjialiang
changed the title
gggrace14
approved these changes
Jul 25, 2023
xiaoxmeng
approved these changes
Jul 25, 2023
prestodb#20372) Summary: Pull Request resolved: prestodb#20372 Removing the relationship of AsyncDataCache inheritance from MemoryAllocator. Now they are depending on each other with registration mechanism. Related tests are refactored to be consistent with the new change. X-link: facebookincubator/velox#5503 Reviewed By: xiaoxmeng Differential Revision: D47536273 Pulled By: tanjialiang fbshipit-source-id: 7749b787bf2a1027b33e02690917c59bb497026c
tanjialiang
force-pushed
the
export-D47536273
branch
from
bf745b6 to
ee92b31
Compare
28 tasks
wypb
pushed a commit
to wypb/presto
that referenced
this pull request
Dec 22, 2023
prestodb#20372) Summary: Pull Request resolved: prestodb#20372 Removing the relationship of AsyncDataCache inheritance from MemoryAllocator. Now they are depending on each other with registration mechanism. Related tests are refactored to be consistent with the new change. X-link: facebookincubator/velox#5503 Reviewed By: xiaoxmeng Differential Revision: D47536273 Pulled By: tanjialiang fbshipit-source-id: 7749b787bf2a1027b33e02690917c59bb497026c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removing the relationship of AsyncDataCache inheritance from MemoryAllocator. Now they are depending on each other with registration mechanism. Related tests are refactored to be consistent with the new change.
Advance Velox version
X-link: facebookincubator/velox#5503
Reviewed By: xiaoxmeng
Differential Revision: D47536273
Pulled By: tanjialiang