Support S3FileIO in Hadoop and Nessie backed Iceberg tables.#20352
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jul 21, 2023
Merged
Support S3FileIO in Hadoop and Nessie backed Iceberg tables.#20352tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
tdcmeehan
approved these changes
Jul 21, 2023
Contributor
|
FYI the issue linked seems irrelevant |
Contributor
Author
My apologies, I meant to link to the Iceberg issue which discusses, in part, the error message. |
Contributor
|
No problem, do you want to update the commit message with |
fcd4548 to
a3e6d50
Compare
28 tasks
| Configuration configuration = new Configuration(false); | ||
|
|
||
| if (hadoopConfigResources.isEmpty()) { | ||
| s3ConfigurationUpdater.updateConfiguration(configuration); |
Member
There was a problem hiding this comment.
Thank you @hmadison for fixing up support for S3-backed Iceberg tables.
I have a question, Is there any reason we are not updating S3 configs always?
I mean we can also have the scenario when we have an iceberg table backed by an S3 filesystem and we want to supply some extra Hadoop config-resource in the catalog, then in that case how s3 configs would be updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Also apache/iceberg#3546.
When an non-Hive catalog is used to back Iceberg, Presto does not set up the
s3,s3a, ors3nfile systems for Hadoop. This prevents non-Hive catalogs from accessing files in object storage without manually passing in a hive configuration.As a small usability improvement, I've updated
IcebergResourceFactoryto applyS3ConfigurationUpdater#updateConfigurationwheniceberg.hadoop.config.resourcesis not set. This has the effect of configuring the object storage file systems for Hadoop by default, with the same configuration properties as the Hive connector.Test plan
I ran (via Docker Compose) a test query which created a new table using the
tpch.tiny.regionwith Nessie/MinIO backed catalog. I then queried the table back out and compared it to the sourcetpch.tiny.regiontable.Test Resources
Docker compose file:
Test Query: