[native] Advance Velox#20342
Merged
majetideepak merged 1 commit intoprestodb:masterfrom Jul 19, 2023
wypb:update-velox
Merged
Conversation
Contributor
Author
|
Hi @majetideepak @mbasmanova, could you help me review this, thanks. |
Collaborator
There was a problem hiding this comment.
do we need the presto_adapters library?
velox_hive_connector library is sufficient?
Contributor
Author
There was a problem hiding this comment.
@majetideepak You are right, I have tested it in the local environment, and removing these also works
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
@wypb thanks for this change.
Can you update the commit message with the description in the PR?
Remove registration of HDFS file-system. This component is now registered in Velox during the Hive connector registration. Remove presto-native-execution/presto_cpp/main/connectors code.
Contributor
Author
|
Hi @majetideepak Deepak, I modified it according to your suggestion, thanks. |
majetideepak
approved these changes
Jul 19, 2023
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove registration of HDFS file-system. This component is now registered in Velox
during the Hive connector registration.
Remove
presto-native-execution/presto_cpp/main/connectorscode.