[native pos] Add tests for json registration of functions with complex types#20298
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Jul 13, 2023
Merged
[native pos] Add tests for json registration of functions with complex types#20298mbasmanova merged 1 commit intoprestodb:masterfrom
mbasmanova merged 1 commit intoprestodb:masterfrom
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47425996 |
pedroerp
force-pushed
the
export-D47425996
branch
from
88f75bc to
e101da0
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47425996 |
pedroerp
force-pushed
the
export-D47425996
branch
from
e101da0 to
15fc45b
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47425996 |
pedroerp
force-pushed
the
export-D47425996
branch
from
15fc45b to
03b6508
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47425996 |
mbasmanova
approved these changes
Jul 13, 2023
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Looks good.
We use [native pos] prefix for commit messages and PR titles when changes are in Presto-on-Spark Native code. We use [native] prefix for Prestissimo changes.
pedroerp
force-pushed
the
export-D47425996
branch
from
03b6508 to
9f14a76
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47425996 |
pedroerp
changed the title
…todb#20298) Summary: Pull Request resolved: prestodb#20298 Adding missing tests for json registration of functions with complex types. In particular, this ensures that the Presto signature serialization format which uses parenthesis (e.g. "array(integer)") is correctly applied for json registration. Reviewed By: mbasmanova Differential Revision: D47425996 fbshipit-source-id: 0715fc0cdfcef483b2b222cc21a75ad5228c6c95
pedroerp
force-pushed
the
export-D47425996
branch
from
9f14a76 to
0f0d60e
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47425996 |
28 tasks
wypb
pushed a commit
to wypb/presto
that referenced
this pull request
Dec 22, 2023
…todb#20298) Summary: Pull Request resolved: prestodb#20298 Adding missing tests for json registration of functions with complex types. In particular, this ensures that the Presto signature serialization format which uses parenthesis (e.g. "array(integer)") is correctly applied for json registration. Reviewed By: mbasmanova Differential Revision: D47425996 fbshipit-source-id: 0715fc0cdfcef483b2b222cc21a75ad5228c6c95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[native pos] Adding missing tests for json registration of functions with complex
types. In particular, this ensures that the Presto signature serialization
format which uses parenthesis (e.g. "array(integer)") is correctly applied for
json registration.
Differential Revision: D47425996