Force using HTTP1.1 on Java 11 or later to avoid thread hanging on driver#20239
Closed
mblanco-denodo wants to merge 1 commit intoprestodb:masterfrom
Closed
Force using HTTP1.1 on Java 11 or later to avoid thread hanging on driver#20239mblanco-denodo wants to merge 1 commit intoprestodb:masterfrom
mblanco-denodo wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
|
Should we try to just remove |
Contributor
Author
|
Closing PR as other approach was merged in #20262 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have experienced deadlocks on the presto jdbc driver when executing presto with java 11 (by default in java 11, HTTP2 is used). We found that forcing to use HTTP 1.1 solves the problem. A similar issue was also reported on Trino: trinodb/trino#1169
Solution to this problem was added by forcing to use HTTP1.1 if the driver is running on java 11. The same change was made to the cli tool too.
Test plan - unit tests in the modified modules
== RELEASE NOTES ==
General Changes
If release note is NOT required, use: