Add support of parquet_writer_version, 1.0 and 2.0#20209
Closed
wanglinsong wants to merge 1 commit intoprestodb:masterfrom
Closed
Add support of parquet_writer_version, 1.0 and 2.0#20209wanglinsong wants to merge 1 commit intoprestodb:masterfrom
wanglinsong wants to merge 1 commit intoprestodb:masterfrom
Conversation
90e0d34 to
84d365f
Compare
yingsu00
reviewed
Jul 6, 2023
Contributor
yingsu00
left a comment
There was a problem hiding this comment.
Looks good, except the Jenkinsfile change which I don't know what is about.
yingsu00
reviewed
Jul 6, 2023
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergSessionProperties.java
Outdated
Show resolved
Hide resolved
Contributor
|
@wanglinsong you also need to update the PR message and add the release note section. |
ff9ce25 to
b156a36
Compare
Contributor
|
@wanglinsong Any update on this PR? |
f0c70a2 to
6b7cef6
Compare
7f47c39 to
114a722
Compare
114a722 to
12ecc43
Compare
Member
Author
Hi @yingsu00 |
d46393e to
12ecc43
Compare
Contributor
|
The work has been finished in another PR. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - Add test cases for versions 1.0 and 2.0.
Enable Hive and Iceberg connectors to use either Parquet writer version 1.0 or 2.0 when writing Parquet data.