[native] Handle same type NULLIF argument#20039
Merged
vermapratyush merged 1 commit intoprestodb:masterfrom Jul 3, 2023
Merged
[native] Handle same type NULLIF argument#20039vermapratyush merged 1 commit intoprestodb:masterfrom
vermapratyush merged 1 commit intoprestodb:masterfrom
Conversation
vermapratyush
force-pushed
the
null-if-test-fix
branch
from
a876214 to
e9cc1a4
Compare
vermapratyush
force-pushed
the
null-if-test-fix
branch
2 times, most recently
from
969b917 to
32f5f26
Compare
amitkdutta
reviewed
Jul 1, 2023
Contributor
There was a problem hiding this comment.
For presto native, coordinator does not know about the worker type. Hence this branch won't be executed for Presto and test fails. How does isNative work here and shall we need to make Presto coordinator recognize worker type? CC: @pranjalssh @mbasmanova
vermapratyush
force-pushed
the
null-if-test-fix
branch
4 times, most recently
from
310a73d to
e3aaeff
Compare
vermapratyush
changed the title
mbasmanova
requested changes
Jul 3, 2023
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
@vermapratyush I don't think this is a good solution. I suggest to revisit #19301 and enhance it to add casts as needed.
vermapratyush
force-pushed
the
null-if-test-fix
branch
2 times, most recently
from
12fd11a to
d30d161
Compare
mbasmanova
reviewed
Jul 3, 2023
Contributor
There was a problem hiding this comment.
Why do you remove this query? Is this accidental?
Member
Author
There was a problem hiding this comment.
Not removed, just moved around. It is the last line in the unit test
This was extracted out into a different unit test: 1d331e0
mbasmanova
reviewed
Jul 3, 2023
presto-main/src/main/java/com/facebook/presto/sql/relational/SqlToRowExpressionTranslator.java
Outdated
Show resolved
Hide resolved
Add support for NULLIF implementation for arguments with same type. Add native-execution-enabled to prestissimo query runner
vermapratyush
force-pushed
the
null-if-test-fix
branch
from
d30d161 to
27363aa
Compare
mbasmanova
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native-execution-enabledin the coordinator to trigger the correct branch in the code.