Skip to content

[native] Advance velox and disable nullif tests. #20037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Jul 1, 2023
Merged

[native] Advance velox and disable nullif tests. #20037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tion/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeGeneralQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ public void testTopN()
assertQuery("SELECT linenumber, NULL FROM lineitem ORDER BY 1 LIMIT 23");
}

@Test
@Test (enabled = false)
Copy link
Copy Markdown
Contributor Author

@amitkdutta amitkdutta Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vermapratyush These tests fails with

VeloxUserError:  NULLIF not supported natively

Disabling for now to keep the CI green. Shall I delete these tests?

Copy link
Copy Markdown
Member

@vermapratyush vermapratyush Jul 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's disable it.
They should still be working, I will have a look.

Copy link
Copy Markdown
Contributor

@mbasmanova mbasmanova Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkdutta @vermapratyush Would one of you create a GitHub issue to describe the problem? It would be nice to do that every time we disable a test and include a link to the issue in a comment next to disabled test.

public void testNullIf()
{
assertQuery("SELECT NULLIF(totalprice, 0) FROM (SELECT SUM(extendedprice) AS totalprice FROM lineitem WHERE shipdate >= '1995-09-01')");
Expand Down
4 changes: 4 additions & 0 deletions ...xecution/src/test/java/com/facebook/presto/spark/TestPrestoSparkNativeGeneralQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,8 @@ public void testSubqueries() {}
@Override
@Ignore
public void testTopN() {}

@Override
@Ignore
public void testInsertIntoSpecialPartitionName(){}
}
7 changes: 6 additions & 1 deletion ...execution/src/test/java/com/facebook/presto/spark/TestPrestoSparkNativeSimpleQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,15 @@ public void testMapOnlyQueries()
{
assertQuery("SELECT * FROM orders");
assertQuery("SELECT orderkey, custkey FROM orders WHERE orderkey <= 200");
assertQuery("SELECT nullif(orderkey, custkey) FROM orders");
assertQuery("SELECT orderkey, custkey FROM orders ORDER BY orderkey LIMIT 4");
}

@Test (enabled = false)
public void testNullIf()
{
assertQuery("SELECT nullif(orderkey, custkey) FROM orders");
}

@Test
public void testAggregations()
{
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Open in desktop
Submodule velox updated 71 files
+3 −0 .circleci/config.yml
+1 −1 build/deps/github_hashes/facebook/folly-rev.txt
+23 −1 velox/benchmarks/tpch/TpchBenchmark.cpp
+4 −0 velox/common/caching/AsyncDataCache.h
+3 −1 velox/common/memory/MallocAllocator.cpp
+4 −0 velox/common/memory/MallocAllocator.h
+23 −0 velox/common/memory/MemoryAllocator.cpp
+7 −0 velox/common/memory/MemoryAllocator.h
+3 −0 velox/common/memory/MmapAllocator.cpp
+4 −0 velox/common/memory/MmapAllocator.h
+13 −0 velox/common/memory/tests/MemoryAllocatorTest.cpp
+7 −0 velox/connectors/Connector.h
+10 −0 velox/connectors/hive/HiveConfig.cpp
+11 −0 velox/connectors/hive/HiveConfig.h
+7 −2 velox/connectors/hive/HiveConnector.h
+14 −9 velox/connectors/hive/HiveDataSink.cpp
+5 −7 velox/connectors/hive/HiveDataSource.cpp
+2 −2 velox/connectors/hive/HiveDataSource.h
+9 −0 velox/core/QueryConfig.h
+8 −8 velox/core/QueryCtx.cpp
+18 −20 velox/core/QueryCtx.h
+9 −0 velox/docs/configs.rst
+4 −0 velox/docs/functions/presto/aggregate.rst
+12 −12 velox/dwio/common/CachedBufferedInput.cpp
+11 −17 velox/dwio/common/CachedBufferedInput.h
+15 −0 velox/dwio/common/Options.h
+7 −13 velox/dwio/dwrf/test/CacheInputTest.cpp
+15 −3 velox/exec/HashProbe.cpp
+8 −0 velox/exec/HashProbe.h
+1 −0 velox/exec/Operator.cpp
+426 −341 velox/exec/tests/HashJoinTest.cpp
+169 −21 velox/exec/tests/TableWriteTest.cpp
+9 −1 velox/exec/tests/utils/Cursor.cpp
+0 −1 velox/exec/tests/utils/HiveConnectorTestBase.cpp
+33 −13 velox/expression/CastExpr.cpp
+19 −16 velox/expression/FieldReference.cpp
+1 −1 velox/expression/tests/ExpressionFuzzerTest.cpp
+16 −14 velox/expression/tests/ExpressionVerifier.cpp
+2 −0 velox/flag_definitions/flags.cpp
+108 −0 velox/functions/prestosql/aggregates/AddressableNonNullValueList.cpp
+98 −0 velox/functions/prestosql/aggregates/AddressableNonNullValueList.h
+1 −0 velox/functions/prestosql/aggregates/AggregateNames.h
+2 −0 velox/functions/prestosql/aggregates/CMakeLists.txt
+16 −0 velox/functions/prestosql/aggregates/MapAggregateBase.cpp
+1 −1 velox/functions/prestosql/aggregates/MapUnionAggregate.cpp
+1 −1 velox/functions/prestosql/aggregates/MaxSizeForStatsAggregate.cpp
+211 −33 velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp
+4 −2 velox/functions/prestosql/aggregates/RegisterAggregateFunctions.cpp
+233 −0 velox/functions/prestosql/aggregates/SetAccumulator.h
+56 −160 velox/functions/prestosql/aggregates/SetAggregates.cpp
+216 −0 velox/functions/prestosql/aggregates/SumDataSizeForStatsAggregate.cpp
+2 −5 velox/functions/prestosql/aggregates/ValueList.cpp
+0 −3 velox/functions/prestosql/aggregates/ValueList.h
+180 −0 velox/functions/prestosql/aggregates/tests/AddressableNonNullValueListTest.cpp
+3 −1 velox/functions/prestosql/aggregates/tests/CMakeLists.txt
+86 −0 velox/functions/prestosql/aggregates/tests/MapUnionAggregationTest.cpp
+92 −0 velox/functions/prestosql/aggregates/tests/MinMaxByAggregationTest.cpp
+56 −0 velox/functions/prestosql/aggregates/tests/SetAggTest.cpp
+304 −0 velox/functions/prestosql/aggregates/tests/SumDataSizeForStatsTest.cpp
+2 −0 velox/functions/prestosql/registration/ComparisonFunctionsRegistration.cpp
+14 −0 velox/functions/prestosql/registration/JsonFunctionsRegistration.cpp
+21 −0 velox/functions/prestosql/tests/ComparisonsTest.cpp
+58 −15 velox/functions/prestosql/tests/JsonFunctionsTest.cpp
+13 −5 velox/functions/remote/client/Remote.cpp
+3 −1 velox/functions/remote/client/Remote.h
+3 −4 velox/functions/remote/client/ThriftClient.cpp
+3 −1 velox/functions/remote/client/ThriftClient.h
+13 −11 velox/functions/remote/client/tests/RemoteFunctionTest.cpp
+8 −3 velox/functions/remote/server/RemoteFunctionService.cpp
+2 −2 velox/functions/sparksql/DateTimeFunctions.h
+5 −3 velox/type/Timestamp.h