[native] Revert NULLIF specialForm support#20031
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Jun 30, 2023
Merged
Conversation
vermapratyush
force-pushed
the
null-if-deprecate
branch
3 times, most recently
from
0f52c7e to
65a7257
Compare
mbasmanova
approved these changes
Jun 30, 2023
presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp
Outdated
Show resolved
Hide resolved
NULLIF expression is now translated to if/else statement in presto (java). Prestissimo does not need to handle this as a specialForm anymore.
vermapratyush
force-pushed
the
null-if-deprecate
branch
from
65a7257 to
26731a5
Compare
This was referenced Jul 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NULLIF expression is now translated to if/else statement in presto (java).
See: #19791
Prestissimo does not need to handle this as a specialForm anymore.