[native pos] Check null pointer before use in spark test#20027
Merged
kewang1024 merged 1 commit intoprestodb:masterfrom Jul 5, 2023
Merged
[native pos] Check null pointer before use in spark test#20027kewang1024 merged 1 commit intoprestodb:masterfrom
kewang1024 merged 1 commit intoprestodb:masterfrom
Conversation
Collaborator
kewang1024
commented
Jun 29, 2023
kewang1024
commented
Contributor
|
@kewang1024 Please rebase on #20014 |
kewang1024
force-pushed
the
Check-null-for-spark
branch
from
39c9db2 to
5df0605
Compare
miaoever
approved these changes
Jun 29, 2023
Contributor
miaoever
left a comment
miaoever
left a comment
There was a problem hiding this comment.
Thanks for the fix, LGTM
amitkdutta
approved these changes
Jun 29, 2023
Contributor
amitkdutta
left a comment
amitkdutta
left a comment
There was a problem hiding this comment.
Thanks @kewang1024 for fixing it quickly.
kewang1024
force-pushed
the
Check-null-for-spark
branch
2 times, most recently
from
2c23b2d to
2943e81
Compare
pranjalssh
approved these changes
Jul 3, 2023
Contributor
|
Checks are failing, stamped in advance |
Member
|
@kewang1024 Can you please rebase and add this test back (it is marked as ignore in master) |
kewang1024
force-pushed
the
Check-null-for-spark
branch
from
2943e81 to
fdfd2a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.