Skip to content

Add missing setter for optimizePayloadJoins in FeatureConfig #19985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschlussel merged 1 commit into from
Jun 26, 2023
Merged

Add missing setter for optimizePayloadJoins in FeatureConfig #19985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,18 +1928,25 @@ public boolean isOptimizeNullsInJoin()
return optimizeNullsInJoin;
}

public boolean isOptimizePayloadJoins()
{
return optimizePayloadJoins;
}

@Config("optimize-nulls-in-join")
public FeaturesConfig setOptimizeNullsInJoin(boolean optimizeNullsInJoin)
{
this.optimizeNullsInJoin = optimizeNullsInJoin;
return this;
}

@Config("optimize-payload-joins")
public FeaturesConfig setOptimizePayloadJoins(boolean optimizePayloadJoins)
{
this.optimizePayloadJoins = optimizePayloadJoins;
return this;
}

public boolean isOptimizePayloadJoins()
{
return optimizePayloadJoins;
}

public String getWarnOnNoTableLayoutFilter()
{
return warnOnNoTableLayoutFilter;
Expand Down
3 changes: 3 additions & 0 deletions presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ public void testDefaults()
.setOptimizeCommonSubExpressions(true)
.setPreferDistributedUnion(true)
.setOptimizeNullsInJoin(false)
.setOptimizePayloadJoins(false)
.setJoinsNotNullInferenceStrategy(FeaturesConfig.JoinNotNullInferenceStrategy.NONE)
.setSkipRedundantSort(true)
.setWarnOnNoTableLayoutFilter("")
Expand Down Expand Up @@ -361,6 +362,7 @@ public void testExplicitPropertyMappings()
.put("optimize-common-sub-expressions", "false")
.put("prefer-distributed-union", "false")
.put("optimize-nulls-in-join", "true")
.put("optimize-payload-joins", "true")
.put("optimizer.joins-not-null-inference-strategy", "USE_FUNCTION_METADATA")
.put("warn-on-no-table-layout-filter", "ry@nlikestheyankees,ds")
.put("inline-sql-functions", "false")
Expand Down Expand Up @@ -540,6 +542,7 @@ public void testExplicitPropertyMappings()
.setOptimizeCommonSubExpressions(false)
.setPreferDistributedUnion(false)
.setOptimizeNullsInJoin(true)
.setOptimizePayloadJoins(true)
.setJoinsNotNullInferenceStrategy(USE_FUNCTION_METADATA)
.setSkipRedundantSort(false)
.setWarnOnNoTableLayoutFilter("ry@nlikestheyankees,ds")
Expand Down