[native] velox::Date and TypeKind::DATE will go away. Prepare for this.#19975
[native] velox::Date and TypeKind::DATE will go away. Prepare for this.#19975spershin wants to merge 1 commit intoprestodb:masterfrom
Conversation
spershin
commented
Jun 23, 2023
|
@spershin : I had #19935 also to handle removing TypeKind::DATE. The intention was to put it along with the Advance Velox version PR to keep the changes isolated. But it might be easier to move the Presto code to We can go ahead with this PR and I'll change #19935 to do post-Velox merge changes. |
| } | ||
|
|
||
| if (type->kind() == TypeKind::DATE) { | ||
| if (type->isDate()) { |
There was a problem hiding this comment.
This block should be moved at line 642 before above conditional statement for TypeKind::INTEGER (see https://github.com/prestodb/presto/pull/19935/files#diff-b596594147f956ff5aadb512a14f1538d5975c551dad6ba773ac266762187734).
Without that change the Velox PR will start using the above conditional block for TypeKind::INTEGER since it will map date to TypeKind::INTEGER and that will take precedence. Instead the date related code should take precedence.