[native] Pass data columns to Velox#19924
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Jul 10, 2023
Merged
Conversation
Yuhta
changed the title
Yuhta
force-pushed
the
datacolumns-to-velox
branch
10 times, most recently
from
e8088e9 to
87d51dd
Compare
Yuhta
force-pushed
the
datacolumns-to-velox
branch
3 times, most recently
from
79d0bbe to
e0d3103
Compare
mbasmanova
approved these changes
Jul 5, 2023
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
Outdated
Show resolved
Hide resolved
Yuhta
force-pushed
the
datacolumns-to-velox
branch
7 times, most recently
from
ece418c to
aa5d90c
Compare
Yuhta
force-pushed
the
datacolumns-to-velox
branch
from
aa5d90c to
a816ee7
Compare
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data columns are necessary in order to determine the schema of TEXTFILE format, hence we pass it to Velox here.