Add configs for ttl of Alluxio cache#19905
Merged
zacw7 merged 1 commit intoprestodb:masterfrom Jun 22, 2023
Merged
Conversation
apc999
approved these changes
Jun 16, 2023
Contributor
apc999
left a comment
apc999
left a comment
There was a problem hiding this comment.
LGTM modulo minor tweaks here
Contributor
There was a problem hiding this comment.
better to keep them alphabetical
Suggested change
| .setTtlEnabled(false) | |
| .setTtlCheckInterval(new Duration(1, HOURS)) | |
| .setTtlCheckInterval(new Duration(1, HOURS)) | |
| .setTtlEnabled(false) |
Contributor
There was a problem hiding this comment.
better to keep them alphabetical
Suggested change
| .put("cache.alluxio.ttl-enabled", "true") | |
| .put("cache.alluxio.ttl-check-interval", "60s") | |
| .put("cache.alluxio.ttl-check-interval", "60s") | |
| .put("cache.alluxio.ttl-enabled", "true") | |
Contributor
There was a problem hiding this comment.
Suggested change
| .setTtlEnabled(true) | |
| .setTtlCheckInterval(new Duration(60, SECONDS)) | |
| .setTtlCheckInterval(new Duration(60, SECONDS)) | |
| .setTtlEnabled(true) |
NikhilCollooru
approved these changes
Jun 20, 2023
Member
|
Thanks @NikhilCollooru for review. @beinan could you please fix the checkstyle issues then we can have this change merged? Thanks! |
beinan
force-pushed
the
presto_local_cache_ttl
branch
from
1ad6c42 to
6edab30
Compare
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the TTL of Alluxio SDK cache