[Native] Fix use-after-free in HTTP callbacks (#19863)#19865
Merged
pranjalssh merged 1 commit intoprestodb:masterfrom Jun 15, 2023
Merged
[Native] Fix use-after-free in HTTP callbacks (#19863)#19865pranjalssh merged 1 commit intoprestodb:masterfrom
pranjalssh merged 1 commit intoprestodb:masterfrom
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D46674355 |
pranjalssh
force-pushed
the
export-D46674355
branch
from
69df4d2 to
023730e
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D46674355 |
pranjalssh
force-pushed
the
export-D46674355
branch
from
023730e to
8b6e41e
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D46674355 |
pranjalssh
force-pushed
the
export-D46674355
branch
from
8b6e41e to
2b62710
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D46674355 |
pranjalssh
force-pushed
the
export-D46674355
branch
from
2b62710 to
71917bd
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D46674355 |
majetideepak
changed the title
majetideepak
previously requested changes
Jun 14, 2023
Collaborator
There was a problem hiding this comment.
@pranjalssh Changes look good to me. Can you please update the commit message with [native] prefix and add a description?
@xiaoxmeng can you take another look? Thanks.
pranjalssh
force-pushed
the
export-D46674355
branch
from
71917bd to
4da1541
Compare
Collaborator
|
@pranjalssh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In the HTTPClient, callbacks are scheduled on an eventBase. HTTPClient is kept alive using a shared_ptr, but it contains a raw pointer to MemoryPool. This MemoryPool may be freed if Task is aborted earlier, but a callback is executed much later. We see crashes related to this when the batch cluster is under heavy load. So the fix here is to keep shared_ptr to MemoryPool isntead of a raw pointer ``` == NO RELEASE NOTE == ``` Pull Request resolved: prestodb#19865 Reviewed By: xiaoxmeng Differential Revision: D46674355 Pulled By: pranjalssh fbshipit-source-id: 9b53deb6357ff87b8e1a992f3205d0ce9d79c05c
pranjalssh
force-pushed
the
export-D46674355
branch
from
4da1541 to
6b38013
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D46674355 |
xiaoxmeng
approved these changes
Jun 14, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@pranjalssh Thanks for the fix!
28 tasks
wypb
pushed a commit
to wypb/presto
that referenced
this pull request
Dec 22, 2023
Summary: In the HTTPClient, callbacks are scheduled on an eventBase. HTTPClient is kept alive using a shared_ptr, but it contains a raw pointer to MemoryPool. This MemoryPool may be freed if Task is aborted earlier, but a callback is executed much later. We see crashes related to this when the batch cluster is under heavy load. So the fix here is to keep shared_ptr to MemoryPool isntead of a raw pointer ``` == NO RELEASE NOTE == ``` Pull Request resolved: prestodb#19865 Reviewed By: xiaoxmeng Differential Revision: D46674355 Pulled By: pranjalssh fbshipit-source-id: 9b53deb6357ff87b8e1a992f3205d0ce9d79c05c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In the HTTPClient, callbacks are scheduled on an eventBase. HTTPClient is kept alive using a shared_ptr, but it contains a raw pointer to MemoryPool. This MemoryPool may be freed if Task is aborted earlier, but a callback is executed much later.
We see crashes related to this when the batch cluster is under heavy load.
So the fix here is to keep shared_ptr to MemoryPool isntead of a raw pointer
Differential Revision: D46674355