Adding support for NO_KEYS_MATCH udf in presto#19838
Adding support for NO_KEYS_MATCH udf in presto#19838rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
|
Refer to #19853 (review) for similar comments |
5980719 to
d059a66
Compare
|
Please address Rebecca's comments from other PR and do same for all PRs. Also make sure all required jobs are passing |
1831fd9 to
f7364ae
Compare
Hi @pranjalssh thanks for your comment. Its address now. Please have a look. |
rschlussel
left a comment
There was a problem hiding this comment.
can you rename the function no_keys_match (or alternatively no_key_matches is fine too)?
I think keeping them consistent with the array ones (NONE_MATCH etc) is ok. But I'm ok with rename as well. |
I'd rather change, as NONE_KEY_MATCH is harder to parse/understand. We can keep internally for these functions though, so: |
I'm trying to keep the name same as array function so that its easier to find. We have |
9f1ab95 to
d18fd8c
Compare
d18fd8c to
7c8f27e
Compare
7c8f27e to
08f4baa
Compare
UDF to check if none of the keys present in the map matches the given predicate
08f4baa to
ca37a61
Compare
Test plan
Added unit tests.
Build successfully using the following terminal command
./mvnw clean install -Dtest=TestNoKeysMatchFunction -fn -pl presto-main