Skip to content

Rewrite expressions in query plans when variables are constant. #19836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feilong-liu merged 3 commits into from
Jan 23, 2024
Merged

Rewrite expressions in query plans when variables are constant. #19836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9be8ef3
Add rule to extract constant variables from projection and filter
feilong-liu Oct 13, 2023
20aa254
Add rules to simplify sort/topn node with constant input
feilong-liu Oct 13, 2023
7cb8801
Add tests for rewrite constant optimizer
feilong-liu Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions presto-benchto-benchmarks/src/test/resources/sql/presto/tpcds/q04.plan.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ local exchange (GATHER, SINGLE, [])
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [c_customer_id])
final aggregation over (c_birth_country, c_customer_id, c_email_address, c_first_name, c_last_name, c_login, c_preferred_cust_flag, d_year)
Copy link
Copy Markdown
Contributor Author

@feilong-liu feilong-liu Jul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constant group by keys pulled up from aggregation

final aggregation over (c_birth_country, c_customer_id, c_email_address, c_first_name, c_last_name, c_login, c_preferred_cust_flag)
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_birth_country, c_customer_id, c_email_address, c_first_name, c_last_name, c_login, c_preferred_cust_flag, d_year])
partial aggregation over (c_birth_country, c_customer_id, c_email_address, c_first_name, c_last_name, c_login, c_preferred_cust_flag, d_year)
remote exchange (REPARTITION, HASH, [c_birth_country, c_customer_id, c_email_address, c_first_name, c_last_name, c_login, c_preferred_cust_flag])
partial aggregation over (c_birth_country, c_customer_id, c_email_address, c_first_name, c_last_name, c_login, c_preferred_cust_flag)
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [ss_customer_sk])
join (INNER, REPLICATED):
Expand All @@ -23,10 +23,10 @@ local exchange (GATHER, SINGLE, [])
scan customer
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_customer_id_247])
final aggregation over (c_birth_country_260, c_customer_id_247, c_email_address_262, c_first_name_254, c_last_name_255, c_login_261, c_preferred_cust_flag_256, d_year_293)
final aggregation over (c_birth_country_260, c_customer_id_247, c_email_address_262, c_first_name_254, c_last_name_255, c_login_261, c_preferred_cust_flag_256)
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_birth_country_260, c_customer_id_247, c_email_address_262, c_first_name_254, c_last_name_255, c_login_261, c_preferred_cust_flag_256, d_year_293])
partial aggregation over (c_birth_country_260, c_customer_id_247, c_email_address_262, c_first_name_254, c_last_name_255, c_login_261, c_preferred_cust_flag_256, d_year_293)
remote exchange (REPARTITION, HASH, [c_birth_country_260, c_customer_id_247, c_email_address_262, c_first_name_254, c_last_name_255, c_login_261, c_preferred_cust_flag_256])
partial aggregation over (c_birth_country_260, c_customer_id_247, c_email_address_262, c_first_name_254, c_last_name_255, c_login_261, c_preferred_cust_flag_256)
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [ss_customer_sk_267])
join (INNER, REPLICATED):
Expand All @@ -39,10 +39,10 @@ local exchange (GATHER, SINGLE, [])
scan customer
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_customer_id_747])
final aggregation over (c_birth_country_760, c_customer_id_747, c_email_address_762, c_first_name_754, c_last_name_755, c_login_761, c_preferred_cust_flag_756, d_year_804)
final aggregation over (c_birth_country_760, c_customer_id_747, c_email_address_762, c_first_name_754, c_last_name_755, c_login_761, c_preferred_cust_flag_756)
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_birth_country_760, c_customer_id_747, c_email_address_762, c_first_name_754, c_last_name_755, c_login_761, c_preferred_cust_flag_756, d_year_804])
partial aggregation over (c_birth_country_760, c_customer_id_747, c_email_address_762, c_first_name_754, c_last_name_755, c_login_761, c_preferred_cust_flag_756, d_year_804)
remote exchange (REPARTITION, HASH, [c_birth_country_760, c_customer_id_747, c_email_address_762, c_first_name_754, c_last_name_755, c_login_761, c_preferred_cust_flag_756])
partial aggregation over (c_birth_country_760, c_customer_id_747, c_email_address_762, c_first_name_754, c_last_name_755, c_login_761, c_preferred_cust_flag_756)
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [cs_bill_customer_sk_767])
join (INNER, REPLICATED):
Expand All @@ -55,10 +55,10 @@ local exchange (GATHER, SINGLE, [])
scan customer
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_customer_id_1140])
final aggregation over (c_birth_country_1153, c_customer_id_1140, c_email_address_1155, c_first_name_1147, c_last_name_1148, c_login_1154, c_preferred_cust_flag_1149, d_year_1197)
final aggregation over (c_birth_country_1153, c_customer_id_1140, c_email_address_1155, c_first_name_1147, c_last_name_1148, c_login_1154, c_preferred_cust_flag_1149)
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_birth_country_1153, c_customer_id_1140, c_email_address_1155, c_first_name_1147, c_last_name_1148, c_login_1154, c_preferred_cust_flag_1149, d_year_1197])
partial aggregation over (c_birth_country_1153, c_customer_id_1140, c_email_address_1155, c_first_name_1147, c_last_name_1148, c_login_1154, c_preferred_cust_flag_1149, d_year_1197)
remote exchange (REPARTITION, HASH, [c_birth_country_1153, c_customer_id_1140, c_email_address_1155, c_first_name_1147, c_last_name_1148, c_login_1154, c_preferred_cust_flag_1149])
partial aggregation over (c_birth_country_1153, c_customer_id_1140, c_email_address_1155, c_first_name_1147, c_last_name_1148, c_login_1154, c_preferred_cust_flag_1149)
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [cs_bill_customer_sk_1160])
join (INNER, REPLICATED):
Expand All @@ -71,10 +71,10 @@ local exchange (GATHER, SINGLE, [])
scan customer
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_customer_id_1661])
final aggregation over (c_birth_country_1674, c_customer_id_1661, c_email_address_1676, c_first_name_1668, c_last_name_1669, c_login_1675, c_preferred_cust_flag_1670, d_year_1718)
final aggregation over (c_birth_country_1674, c_customer_id_1661, c_email_address_1676, c_first_name_1668, c_last_name_1669, c_login_1675, c_preferred_cust_flag_1670)
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_birth_country_1674, c_customer_id_1661, c_email_address_1676, c_first_name_1668, c_last_name_1669, c_login_1675, c_preferred_cust_flag_1670, d_year_1718])
partial aggregation over (c_birth_country_1674, c_customer_id_1661, c_email_address_1676, c_first_name_1668, c_last_name_1669, c_login_1675, c_preferred_cust_flag_1670, d_year_1718)
remote exchange (REPARTITION, HASH, [c_birth_country_1674, c_customer_id_1661, c_email_address_1676, c_first_name_1668, c_last_name_1669, c_login_1675, c_preferred_cust_flag_1670])
partial aggregation over (c_birth_country_1674, c_customer_id_1661, c_email_address_1676, c_first_name_1668, c_last_name_1669, c_login_1675, c_preferred_cust_flag_1670)
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [ws_bill_customer_sk_1682])
join (INNER, REPLICATED):
Expand All @@ -87,10 +87,10 @@ local exchange (GATHER, SINGLE, [])
scan customer
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_customer_id_2054])
final aggregation over (c_birth_country_2067, c_customer_id_2054, c_email_address_2069, c_first_name_2061, c_last_name_2062, c_login_2068, c_preferred_cust_flag_2063, d_year_2111)
final aggregation over (c_birth_country_2067, c_customer_id_2054, c_email_address_2069, c_first_name_2061, c_last_name_2062, c_login_2068, c_preferred_cust_flag_2063)
local exchange (GATHER, SINGLE, [])
remote exchange (REPARTITION, HASH, [c_birth_country_2067, c_customer_id_2054, c_email_address_2069, c_first_name_2061, c_last_name_2062, c_login_2068, c_preferred_cust_flag_2063, d_year_2111])
partial aggregation over (c_birth_country_2067, c_customer_id_2054, c_email_address_2069, c_first_name_2061, c_last_name_2062, c_login_2068, c_preferred_cust_flag_2063, d_year_2111)
remote exchange (REPARTITION, HASH, [c_birth_country_2067, c_customer_id_2054, c_email_address_2069, c_first_name_2061, c_last_name_2062, c_login_2068, c_preferred_cust_flag_2063])
partial aggregation over (c_birth_country_2067, c_customer_id_2054, c_email_address_2069, c_first_name_2061, c_last_name_2062, c_login_2068, c_preferred_cust_flag_2063)
join (INNER, PARTITIONED):
remote exchange (REPARTITION, HASH, [ws_bill_customer_sk_2075])
join (INNER, REPLICATED):
Expand Down
Loading