Skip to content

Adding support for ANY_KEYS_MATCH udf in presto#19814

Merged
rschlussel merged 1 commit intoprestodb:masterfrom
jainavi17:map_any_match_key
Jun 26, 2023
Merged

Adding support for ANY_KEYS_MATCH udf in presto#19814
rschlussel merged 1 commit intoprestodb:masterfrom
jainavi17:map_any_match_key

Conversation

@jainavi17
Copy link
Contributor

@jainavi17 jainavi17 commented Jun 7, 2023

Test plan

Added unit tests.
Build successfully using the following terminal command

  • ./mvnw clean install -Dtest=TestAnyKeysMatchFunction -fn -pl presto-main
== RELEASE NOTES ==

General Changes
* Add function :func:`any_keys_match`

@jainavi17 jainavi17 requested a review from a team as a code owner June 7, 2023 11:47
@jainavi17 jainavi17 requested a review from presto-oss June 7, 2023 11:47
@jainavi17 jainavi17 force-pushed the map_any_match_key branch from 67507d3 to a2d6c1a Compare June 7, 2023 12:29
@kaikalur kaikalur requested a review from feilong-liu June 7, 2023 13:29
@jainavi17 jainavi17 force-pushed the map_any_match_key branch 2 times, most recently from 5562a84 to 9d4870e Compare June 9, 2023 21:17
@feilong-liu
Copy link
Contributor

For the release note, your change is not specifically related to hive, so do not need to include the hive section.
Also the description of the udf should be a sub bullet point, something like:

  • add xxx
    • xxxx

@feilong-liu
Copy link
Contributor

For the release note, your change is not specifically related to hive, so do not need to include the hive section. Also the description of the udf should be a sub bullet point, something like:

  • add xxx

    • xxxx

And the same for the other two PRs

@feilong-liu
Copy link
Contributor

Check the maven checks failures, you have code style violations.

@jainavi17 jainavi17 force-pushed the map_any_match_key branch 2 times, most recently from 1c53139 to b7b9746 Compare June 21, 2023 22:01
Copy link
Contributor

@rschlussel rschlussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the function any_key_matches or any_keys_match? just to make it better English.

@rschlussel
Copy link
Contributor

for all the release notes for added functions, you can just add a reference to the documentation instead of rewriting the docs as the release note. You can add a link to the documentation using the :func:function_name syntax

e.g.

* Add function :func:`any_keys_match`

@jainavi17 jainavi17 force-pushed the map_any_match_key branch from fcb9703 to f34bf5b Compare June 24, 2023 04:15
@jainavi17 jainavi17 changed the title Adding support for ANY_KEY_MATCH udf in presto Adding support for ANY_KEYS_MATCH udf in presto Jun 24, 2023
@jainavi17 jainavi17 force-pushed the map_any_match_key branch from f34bf5b to 37b8eeb Compare June 24, 2023 04:19
UDF to check if any keys of a map match the given predicate
@jainavi17 jainavi17 force-pushed the map_any_match_key branch from 37b8eeb to 73c2cdd Compare June 24, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants