Add updated guidelines for committers and code owners#19803
Add updated guidelines for committers and code owners#19803tdcmeehan wants to merge 1 commit intoprestodb:masterfrom
Conversation
tdcmeehan
requested review from
highker,
majetideepak,
presto-oss,
rongrong,
rschlussel,
yingsu00 and
zhenxiao
tdcmeehan
changed the title
tdcmeehan
force-pushed
the
codeowners
branch
from
bfe00c5 to
b6b8d51
Compare
tdcmeehan
requested review from
aditi-pandit,
beinan and
xiaoxmeng
and removed request for
rongrong
|
|
||
| The [CODEOWNERS](CODEOWNERS) file should list the backup committers, called the [committers](https://github.com/orgs/prestodb/teams/committers) team, alongside any file grouping, and as a general | ||
| fallback for file groupings that don't exist. The TSC may add additional backup committers as needed. The requirement for addition to the backup committers group is two or more code owners responsibilities in the Presto repository | ||
| and approval from the TSC. To nominate someone (including yourself) to be included in the backup committers team, send an email requesting this to [operations@prestodb.io](mailto:operations@prestodb.io). |
There was a problem hiding this comment.
curious why this is done by email to operations rather than being the same process as for codeownership (i do think it's nice to allow people to nominate themselves in general, so I like that that's an additional option if you don't want to go directly through a tsc member).
Also, the codeowner guidelines need to be updated codeowner nominations are voted on in the tsc-private mailing list and then submitted as a PR just to update the file, but the voting is not done by PR submission.
| Committers are responsible for providing final approval of pull requests in a timely manner. If the committer is unable to provide timely review, they should assign the pull request to another committer. | ||
|
|
||
| The [CODEOWNERS](CODEOWNERS) file should list the backup committers, called the [committers](https://github.com/orgs/prestodb/teams/committers) team, alongside any file grouping, and as a general | ||
| fallback for file groupings that don't exist. The TSC may add additional backup committers as needed. The requirement for addition to the backup committers group is two or more code owners responsibilities in the Presto repository |
There was a problem hiding this comment.
I think having people with broad committership rights is valuable, so I think we should encourage growing the list of backup committers (while maintaining high expectations of anyone nominated). 2 things I'm thinking about
- should we require actually being codeowner of two areas or demonstrating that you could be codeowner of two areas. It would be nice to be able to condense some of the beaurocracy if you know you plan to nominate someone as a committer after the second codeowner nomination. If prefered it could be submitted as a two part nomination (e.g. I'd like to nominate <person> to be codeowner of <second area>. I'd also like to nominate them to be a global committer), and then people could vote on both aspects
- Could there be a way to add people as committers who don't have a specific second area that they could obviously codeowners for, but maybe they have a core area and scattered contributions in many different areas? For example, in any particular second area they may only have one or two contributions, but they've made contributions in a variety of areas, and in that way have demonstrated strong skills/knowledge in the Presto code base.
There was a problem hiding this comment.
+1. Codeowners of two or more areas is definitely good. Deep in one area with contributions in a variety of areas is also good.
Not sure if we need to explicitly make two or more code owners as a pre-requisite
|
We're reworking this internally amongst the TSC. We'll open a new PR with updated guidelines soon. |
4 participants
Add updated guidelines for committers and code owners.
This requires as a pre-requisite before merge that an administrator create the
backup-codeownersgroup that is populated with members ofcommitters.