Track applicable optimizations that were disabled with a flag#19772
Merged
mlyublena merged 1 commit intoprestodb:masterfrom Jun 13, 2023
Merged
Track applicable optimizations that were disabled with a flag#19772mlyublena merged 1 commit intoprestodb:masterfrom
mlyublena merged 1 commit intoprestodb:masterfrom
Conversation
b9bb478 to
d96fe63
Compare
feilong-liu
reviewed
Jun 6, 2023
presto-main/src/main/java/com/facebook/presto/sql/Optimizer.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/IterativeOptimizer.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/planPrinter/PlanPrinter.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/sql/planner/planPrinter/TestJsonRenderer.java
Outdated
Show resolved
Hide resolved
d96fe63 to
a67f5ba
Compare
feilong-liu
approved these changes
Jun 7, 2023
Contributor
|
Failing with check style |
608d2c4 to
945bc50
Compare
pranjalssh
approved these changes
Jun 9, 2023
presto-main/src/main/java/com/facebook/presto/sql/planner/optimizations/PlanOptimizer.java
Outdated
Show resolved
Hide resolved
e3b484b to
2a72c33
Compare
2a72c33 to
c25c10c
Compare
mbasmanova
reviewed
Jun 16, 2023
Contributor
mbasmanova
left a comment
There was a problem hiding this comment.
@mlyublena PrefilterForLimitingAggregation.java.orig seems to be blocking diff train. Why is this file part of the PR? Looks like a left over from debugging / development.
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends previous change, which tracked which rule-based optimizations triggered for a query in the following shape:
This PR adds the following:
This information is only printed if the flag verbose_optimizer_info_enabled is true.