Skip to content

Update Joda to 2.12.2#19758

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
sanchitkashyap:update_joda
Jun 9, 2023
Merged

Update Joda to 2.12.2#19758
tdcmeehan merged 1 commit intoprestodb:masterfrom
sanchitkashyap:update_joda

Conversation

@sanchitkashyap
Copy link
Copy Markdown
Contributor

@sanchitkashyap sanchitkashyap commented May 31, 2023 •
edited by tdcmeehan
Loading

Fixes #19819

Add Pacific/Kanton, Europe/Kyiv, America/Ciudad_Juarez time zone

Cherrypick of trinodb/trino#10679
Cherrypick of trinodb/trino#14684
Cherrypick of trinodb/trino#15754

Test plan - Unit tests

== RELEASE NOTES ==

General Changes
* Update Joda to 2.12.2.  Note: a corresponding update to the Java runtime should also be made to ensure consistent timezone data.

@sanchitkashyap sanchitkashyap requested a review from a team as a code owner May 31, 2023 10:36
@sanchitkashyap sanchitkashyap requested a review from ajaygeorge May 31, 2023 10:36
@sanchitkashyap
Copy link
Copy Markdown
Contributor Author

sanchitkashyap commented Jun 8, 2023

Can you please review this PR? @jainxrohit @rschlussel
Thanks!

@fgwang7w
Copy link
Copy Markdown
Member

fgwang7w commented Jun 8, 2023

@tdcmeehan FYI

fgwang7w
fgwang7w previously requested changes Jun 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fgwang7w fgwang7w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix so quickly! @sanchitkashyap
Given this is a cherry-pick, could you please follow the community Review and Commit guidelines to preserve the commit of cherry-picks so it can be easily back tracked and correlate the original commit for review? https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#attribution

In addition, is there any additional handling needed to take jvm tzdata into account?

@tdcmeehan
Copy link
Copy Markdown
Contributor

tdcmeehan commented Jun 8, 2023

LGTM. In the future please properly attribute the origin of the changes with Co-authored-by. I've done this for this PR, just FYI for the future.

@tdcmeehan tdcmeehan self-assigned this Jun 8, 2023
@sanchitkashyap @findepi
@sopel39 @wendigo
Update Joda to 2.12.2
137bc29 
Add Pacific/Kanton, Europe/Kyiv, America/Ciudad_Juarez time zone

Cherrypick of trinodb/trino#10679
Cherrypick of trinodb/trino#14684
Cherrypick of trinodb/trino#15754

Co-authored-by: Piotr Findeisen <findepi@users.noreply.github.com>
Co-authored-by: Karol Sobczak <sopel39@users.noreply.github.com>
Co-authored-by: Mateusz Gajewski <mateusz.gajewski@gmail.com>
@sanchitkashyap
Copy link
Copy Markdown
Contributor Author

sanchitkashyap commented Jun 9, 2023

Thanks for reviewing @tdcmeehan!
The failing test looks unrelated, and it actually passed in the previous run.

@tdcmeehan tdcmeehan dismissed fgwang7w’s stale review June 9, 2023 14:15

Comment is addressed

@tdcmeehan tdcmeehan merged commit c06afb4 into prestodb:master Jun 9, 2023
@sanchitkashyap sanchitkashyap deleted the update_joda branch June 9, 2023 17:08
This was referenced Aug 23, 2023
Closed
Merged
@wypb wypb mentioned this pull request Sep 21, 2023
Closed
facebook-github-bot pushed a commit to facebookincubator/velox that referenced this pull request Sep 21, 2023
@wypb @facebook-github-bot
Add Pacific/Kanton, Europe/Kyiv, America/Ciudad_Juarez time zones (#6670
3bb636b 
)

Summary:
Presto 0.282 adds three new timezones: Pacific/Kanton, Europe/Kyiv, America/Ciudad_Juarez: prestodb/presto#19758, So velox should be consistent with it

Pull Request resolved: #6670

Reviewed By: Yuhta

Differential Revision: D49495464

Pulled By: mbasmanova

fbshipit-source-id: 62525616cd8450728dd377fa8e06837fbe849159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@fgwang7w fgwang7w fgwang7w left review comments

@ajaygeorge ajaygeorge Awaiting requested review from ajaygeorge ajaygeorge is a code owner automatically assigned from prestodb/committers

Assignees

@tdcmeehan tdcmeehan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

joda version upgrade needed to take into account latest tzdata

3 participants

@sanchitkashyap @fgwang7w @tdcmeehan