Skip to content

Remove 'Experimental' Prefix from Dynamic Filtering as It's Now Stable #19715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Jun 12, 2023
Merged

Remove 'Experimental' Prefix from Dynamic Filtering as It's Now Stable #19715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,17 +1125,17 @@ public SystemSessionProperties(
value -> value != null ? value.toString() : null),
booleanProperty(
ENABLE_DYNAMIC_FILTERING,
"Experimental: Enable dynamic filtering",
"Enable dynamic filtering",
featuresConfig.isEnableDynamicFiltering(),
false),
integerProperty(
DYNAMIC_FILTERING_MAX_PER_DRIVER_ROW_COUNT,
"Experimental: maximum number of build-side rows to be collected for dynamic filtering per-driver",
"Maximum number of build-side rows to be collected for dynamic filtering per-driver",
featuresConfig.getDynamicFilteringMaxPerDriverRowCount(),
false),
new PropertyMetadata<>(
DYNAMIC_FILTERING_MAX_PER_DRIVER_SIZE,
"Experimental: maximum number of bytes to be collected for dynamic filtering per-driver",
"Maximum number of bytes to be collected for dynamic filtering per-driver",
VARCHAR,
DataSize.class,
featuresConfig.getDynamicFilteringMaxPerDriverSize(),
Expand Down
13 changes: 9 additions & 4 deletions presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import com.facebook.airlift.configuration.Config;
import com.facebook.airlift.configuration.ConfigDescription;
import com.facebook.airlift.configuration.DefunctConfig;
import com.facebook.airlift.configuration.LegacyConfig;
import com.facebook.presto.common.function.OperatorType;
import com.facebook.presto.operator.aggregation.arrayagg.ArrayAggGroupImplementation;
import com.facebook.presto.operator.aggregation.histogram.HistogramGroupImplementation;
Expand Down Expand Up @@ -1471,7 +1472,8 @@ public boolean isEnableDynamicFiltering()
return enableDynamicFiltering;
}

@Config("experimental.enable-dynamic-filtering")
@Config("enable-dynamic-filtering")
@LegacyConfig("experimental.enable-dynamic-filtering")
public FeaturesConfig setEnableDynamicFiltering(boolean value)
{
this.enableDynamicFiltering = value;
Expand All @@ -1483,7 +1485,8 @@ public int getDynamicFilteringMaxPerDriverRowCount()
return dynamicFilteringMaxPerDriverRowCount;
}

@Config("experimental.dynamic-filtering-max-per-driver-row-count")
@Config("dynamic-filtering-max-per-driver-row-count")
@LegacyConfig("experimental.dynamic-filtering-max-per-driver-row-count")
public FeaturesConfig setDynamicFilteringMaxPerDriverRowCount(int dynamicFilteringMaxPerDriverRowCount)
{
this.dynamicFilteringMaxPerDriverRowCount = dynamicFilteringMaxPerDriverRowCount;
Expand All @@ -1496,7 +1499,8 @@ public DataSize getDynamicFilteringMaxPerDriverSize()
return dynamicFilteringMaxPerDriverSize;
}

@Config("experimental.dynamic-filtering-max-per-driver-size")
@Config("dynamic-filtering-max-per-driver-size")
@LegacyConfig("experimental.dynamic-filtering-max-per-driver-size")
public FeaturesConfig setDynamicFilteringMaxPerDriverSize(DataSize dynamicFilteringMaxPerDriverSize)
{
this.dynamicFilteringMaxPerDriverSize = dynamicFilteringMaxPerDriverSize;
Expand All @@ -1508,7 +1512,8 @@ public int getDynamicFilteringRangeRowLimitPerDriver()
return dynamicFilteringRangeRowLimitPerDriver;
}

@Config("experimental.dynamic-filtering-range-row-limit-per-driver")
@Config("dynamic-filtering-range-row-limit-per-driver")
@LegacyConfig("experimental.dynamic-filtering-range-row-limit-per-driver")
@ConfigDescription("Maximum number of build-side rows per driver up to which min and max values will be collected for dynamic filtering")
public FeaturesConfig setDynamicFilteringRangeRowLimitPerDriver(int dynamicFilteringRangeRowLimitPerDriver)
{
Expand Down
8 changes: 4 additions & 4 deletions presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,10 @@ public void testExplicitPropertyMappings()
.put("experimental.iterative-optimizer-enabled", "false")
.put("experimental.iterative-optimizer-timeout", "10s")
.put("experimental.runtime-optimizer-enabled", "true")
.put("experimental.enable-dynamic-filtering", "true")
.put("experimental.dynamic-filtering-max-per-driver-row-count", "256")
.put("experimental.dynamic-filtering-max-per-driver-size", "64kB")
.put("experimental.dynamic-filtering-range-row-limit-per-driver", "1000")
.put("enable-dynamic-filtering", "true")
.put("dynamic-filtering-max-per-driver-row-count", "256")
.put("dynamic-filtering-max-per-driver-size", "64kB")
.put("dynamic-filtering-range-row-limit-per-driver", "1000")
.put("experimental.fragment-result-caching-enabled", "true")
.put("experimental.enable-stats-calculator", "false")
.put("experimental.enable-stats-collection-for-temporary-table", "true")
Expand Down