Supporting worker isolation using worker pool#19342
Merged
ajaygeorge merged 1 commit intoprestodb:masterfrom Jun 28, 2023
Merged
Supporting worker isolation using worker pool#19342ajaygeorge merged 1 commit intoprestodb:masterfrom
ajaygeorge merged 1 commit intoprestodb:masterfrom
Conversation
abhiseksaikia
force-pushed
the
apr_worker_isolation
branch
from
a4fbcc5 to
d15bc6d
Compare
abhiseksaikia
changed the title
abhiseksaikia
force-pushed
the
apr_worker_isolation
branch
from
d15bc6d to
2096020
Compare
wanglinsong
requested changes
Apr 10, 2023
Member
wanglinsong
left a comment
wanglinsong
left a comment
There was a problem hiding this comment.
Please update release notes based on the guidelines. https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines#order-of-changes
Contributor
Author
@wanglinsong Thanks for early heads up! The PR is not ready for review yet, I will mark it as ready for review once I reformat it and address few things |
abhiseksaikia
force-pushed
the
apr_worker_isolation
branch
from
2096020 to
ef5c6c8
Compare
wanglinsong
approved these changes
Apr 12, 2023
ajaygeorge
reviewed
Apr 21, 2023
Contributor
ajaygeorge
left a comment
ajaygeorge
left a comment
There was a problem hiding this comment.
Mostly looks good. Added some comments
presto-main/src/main/java/com/facebook/presto/execution/scheduler/NodeScheduler.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/ServerConfig.java
Outdated
Show resolved
Hide resolved
abhiseksaikia
force-pushed
the
apr_worker_isolation
branch
5 times, most recently
from
aa473f8 to
605e32e
Compare
abhiseksaikia
force-pushed
the
apr_worker_isolation
branch
3 times, most recently
from
b12eae4 to
8b2ac9a
Compare
ajaygeorge
approved these changes
Jun 26, 2023
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Outdated
Show resolved
Hide resolved
We can split the workers into two pools: the leaf worker pool and the intermediate worker pool. The leaf worker pool will contain workers responsible for leaf stage tasks, while the intermediate worker pool will contain workers responsible for intermediate stage tasks. Worker isolation gives us the flexibility to scale the two pools differently
abhiseksaikia
force-pushed
the
apr_worker_isolation
branch
from
8b2ac9a to
94490df
Compare
Contributor
|
CC: @pranjalssh |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can split the workers into two pools: the leaf worker pool and the intermediate worker pool. The leaf worker pool will contain workers responsible for leaf stage tasks, while the intermediate worker pool will contain workers responsible for intermediate stage tasks. Worker isolation gives us the flexibility to scale the two pools differently
Test plan -