[native] Rebuild protocols#19284
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Mar 30, 2023
Merged
Conversation
mbasmanova
force-pushed
the
fix-protocols
branch
from
6a2742f to
718be07
Compare
xiaoxmeng
approved these changes
Mar 29, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@mbasmanova thanks for the fix!
mbasmanova
force-pushed
the
fix-protocols
branch
2 times, most recently
from
fb700fb to
cbfc5f6
Compare
mbasmanova
force-pushed
the
fix-protocols
branch
from
cbfc5f6 to
92ddca6
Compare
Contributor
|
Thanks @mbasmanova for fixing it so quickly! |
amitkdutta
approved these changes
Mar 30, 2023
jainxrohit
approved these changes
Mar 30, 2023
Contributor
jainxrohit
left a comment
jainxrohit
left a comment
There was a problem hiding this comment.
Thanks for fixing it! Native builds has been very flaky recently so missed seeing the failures.
arunthirupathi
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These got broken by #19265
Used instructions from https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/presto_protocol/README.md
CC: @jainxrohit