Add pluggable QueryAnalyzer interface#19093
Merged
jainxrohit merged 1 commit intoprestodb:masterfrom Feb 23, 2023
Merged
Conversation
jainxrohit
force-pushed
the
rj_query_analyzer
branch
2 times, most recently
from
d905538 to
ca679f7
Compare
jainxrohit
requested review from
mlyublena and
pranjalssh
and removed request for
pranjalssh
rschlussel
reviewed
Feb 22, 2023
Contributor
rschlussel
left a comment
rschlussel
left a comment
There was a problem hiding this comment.
i like this approach. Can you add some context about this change to the body of the commit message.
presto-main/src/main/java/com/facebook/presto/execution/DropFunctionTask.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/CoordinatorModule.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/StatisticsAggregationPlanner.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/testing/LocalQueryRunner.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/transaction/InMemoryTransactionManager.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/analyzer/QueryAnalysis.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/analyzer/QueryAnalyzer.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/util/AnalyzerUtil.java
Outdated
Show resolved
Hide resolved
jainxrohit
force-pushed
the
rj_query_analyzer
branch
from
ca679f7 to
bf71c47
Compare
jainxrohit
changed the title
jainxrohit
force-pushed
the
rj_query_analyzer
branch
5 times, most recently
from
b01a9a2 to
561dfc7
Compare
mlyublena
reviewed
Feb 23, 2023
presto-spi/src/main/java/com/facebook/presto/spi/analyzer/QueryAnalysis.java
Outdated
Show resolved
Hide resolved
jainxrohit
force-pushed
the
rj_query_analyzer
branch
from
561dfc7 to
587036f
Compare
rschlussel
reviewed
Feb 23, 2023
presto-main/src/main/java/com/facebook/presto/sql/planner/LogicalPlanner.java
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Feb 23, 2023
Contributor
rschlussel
left a comment
rschlussel
left a comment
There was a problem hiding this comment.
other than the comment about variableAllocator, the rest looks good.
presto-spi/src/main/java/com/facebook/presto/spi/analyzer/QueryAnalysis.java
Outdated
Show resolved
Hide resolved
jainxrohit
force-pushed
the
rj_query_analyzer
branch
from
587036f to
ad31b2b
Compare
This commit adds a pluggable QueryAnalyzer interface for analyzing queries and creating logical plans. This change also integrates the default built-in analyzer in the pluggable analyzer interface. At this moment only SQLQueryExecutionFactory is enabled with pluggable analyzer interfaces. SessionDefinition and DDLDefinition still works with hardcoded builtInAnalyzer.
jainxrohit
force-pushed
the
rj_query_analyzer
branch
from
ad31b2b to
83ba2e5
Compare
rschlussel
approved these changes
Feb 23, 2023
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a pluggable QueryAnalyzer interface for analyzing queries and creating logical plans.
This change also integrates the default built-in analyzer in the pluggable analyzer interface.
At this moment only SQLQueryExecutionFactory is enabled with pluggable analyzer interfaces. SessionDefinition and DDLDefinition still works with hardcoded builtInAnalyzer.