Update README on velox and prestissimo#19022
Merged
mshang816 merged 1 commit intoprestodb:masterfrom Feb 8, 2023
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D43064589 |
ajaygeorge
approved these changes
Feb 7, 2023
majetideepak
reviewed
Feb 7, 2023
presto-native-execution/README.md
Outdated
Collaborator
There was a problem hiding this comment.
We decided to use Prestissimo instead of presto native execution.
Prestissimo - C++ Presto worker implementation using Velox is probably apt.
Contributor
Author
There was a problem hiding this comment.
Prestissimo - C++ Presto worker implementation using Velox
That makes sense. Will update the text accordingly.
majetideepak
requested changes
Feb 7, 2023
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
@mshang816 added a comment on the description
Summary: Pull Request resolved: prestodb#19022 This is a mono-diff contains changes on both velox and presto-trunk diff-train-skip-merge Reviewed By: ajaygeorge, kgpai Differential Revision: D43064589 fbshipit-source-id: c18a222db334c8599f8f20745c63180c371b609d
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D43064589 |
mshang816
force-pushed
the
export-D43064589
branch
from
5f316b2 to
29fe705
Compare
mshang816
added a commit
to mshang816/velox-1
that referenced
this pull request
Feb 7, 2023
Summary: X-link: prestodb/presto#19022 This is a mono-diff contains changes on both velox and presto-trunk diff-train-skip-merge Reviewed By: ajaygeorge, kgpai Differential Revision: D43064589 fbshipit-source-id: f375a00fde604734f7c396480394c5cb2f6ed67e
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: #3966 X-link: prestodb/presto#19022 This is a mono-diff contains changes on both velox and presto-trunk diff-train-skip-merge Reviewed By: ajaygeorge, kgpai Differential Revision: D43064589 fbshipit-source-id: f0ac55e473bbfd93f128626bae4119e40122cc9d
12 tasks
wypb
pushed a commit
to wypb/presto
that referenced
this pull request
Dec 22, 2023
Summary: Pull Request resolved: prestodb#19022 This is a mono-diff contains changes on both velox and presto-trunk diff-train-skip-merge Reviewed By: ajaygeorge, kgpai Differential Revision: D43064589 fbshipit-source-id: c18a222db334c8599f8f20745c63180c371b609d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a mono-diff contains changes on both velox and presto-trunk
diff-train-skip-merge
Differential Revision: D43064589