[native] Remove deprecated.legacy-date-timestamp-to-varchar-coercion option from native e2e tests.#19010
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Feb 2, 2023
Conversation
…from native e2e test.
amitkdutta
requested review from
aditi-pandit,
rschlussel,
spershin and
xiaoxmeng
xiaoxmeng
approved these changes
Feb 2, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@amitkdutta LGTM. Thanks!
gggrace14
approved these changes
Feb 2, 2023
12 tasks
Contributor
|
@amitkdutta this needs to be added in the release notes, can you please add a line about it here, I can add that to the release notes. Refer - #19143 (review) |
Contributor
|
How about the "Remove |
Merged
amitkdutta
changed the title
amitkdutta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deprecated.legacy-date-timestamp-to-varchar-coercionwas developed for Raptor to Presto migration. We are removing this option from Presto. Here updating the tests and changing sql so that this option can be deleted without any issue.