Skip to content

Fix blocking resource groups when query queue full #18910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Jan 18, 2023
Merged

Fix blocking resource groups when query queue full #18910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions ...ain/src/main/java/com/facebook/presto/execution/resourceGroups/InternalResourceGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,7 @@ protected void setDirty()

public void run(ManagedQueryExecution query)
{
boolean isQueryQueueFull = false;
synchronized (root) {
if (!subGroups.isEmpty()) {
throw new PrestoException(INVALID_RESOURCE_GROUP, format("Cannot add queries to %s. It is not a leaf group.", id));
Expand All @@ -697,21 +698,25 @@ public void run(ManagedQueryExecution query)
group = group.parent.get();
}
if (!canQueue && !canRun) {
query.fail(new QueryQueueFullException(id));
return;
}
query.setResourceGroupQueryLimits(perQueryLimits);
if (canRun && queuedQueries.isEmpty()) {
startInBackground(query);
isQueryQueueFull = true;
}
else {
enqueueQuery(query);
}
query.addStateChangeListener(state -> {
if (state.isDone()) {
queryFinished(query);
query.setResourceGroupQueryLimits(perQueryLimits);
if (canRun && queuedQueries.isEmpty()) {
startInBackground(query);
}
});
else {
enqueueQuery(query);
}
query.addStateChangeListener(state -> {
if (state.isDone()) {
queryFinished(query);
}
});
}
}
if (isQueryQueueFull) {
query.fail(new QueryQueueFullException(id));
}
}

Expand Down