Fix bug in CombineApproxPercentileFunctions with duplicate aggregation expressions#18889
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jan 3, 2023
Conversation
feilong-liu
force-pushed
the
fix_approx_percentile_optimization
branch
from
33646a7 to
d69c56d
Compare
The current implementation assumes that there are no duplicate aggregation expressions, which does not hold in some cases. In this PR, I filter out these aggregations to fix the bug.
feilong-liu
force-pushed
the
fix_approx_percentile_optimization
branch
from
d69c56d to
d07f88d
Compare
kaikalur
approved these changes
Dec 30, 2022
rschlussel
approved these changes
Jan 3, 2023
Contributor
|
On second thoughts, talking to Feilong offline, I feel we should not have special cases like this, instead fix up the optimization to project out original expressions (multiple times if needed). |
Contributor
|
Sounds good. let's do a follow up fix, but in the meantime at least the queries will stop failing. |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation assumes that there are no duplicate aggregation expressions, which does not hold in some cases. To solve this problem, I need to either 1) fix the code to take care of the duplicates or 2) filter these aggregations which have duplicates. Since approach 1 will complicate the code and it's not a common case, I decided to take approach 2 to filter out these aggregations to fix the bug.
Test plan - (Please fill in how you tested your changes)
Add unit tests.