Fix BatchTaskUpdateRequest failures#18837
Merged
tanjialiang merged 2 commits intoprestodb:masterfrom Dec 23, 2022
Merged
Conversation
miaoever
force-pushed
the
fix_batchTaskUpdate
branch
from
575e36a to
1ea4e2e
Compare
tanjialiang
approved these changes
Dec 22, 2022
Contributor
tanjialiang
left a comment
tanjialiang
left a comment
There was a problem hiding this comment.
Thanks MJ good catches. Just some minor stuff.
Contributor
There was a problem hiding this comment.
nice fix. Can we also add comments on top of this endpoint to note the importance of the ordering?
Contributor
There was a problem hiding this comment.
typo:
havePartitionedOutputNode -> have PartitionedOutputNode
Contributor
There was a problem hiding this comment.
VELOX_CHECK_NON_NULL or VELOX_CHECK(partitionedOutputNode != nullptr)
Contributor
There was a problem hiding this comment.
Ah okay so this check is actually wrong. Good to know table write ends with an partitioned output node.
Contributor
|
Oh also if you want these to be effective immediately you will also need manually create an identical diff in fbcode. Otherwise it takes a week for the changes to get in. |
miaoever
force-pushed
the
fix_batchTaskUpdate
branch
2 times, most recently
from
32fe94e to
ecac9c5
Compare
miaoever
force-pushed
the
fix_batchTaskUpdate
branch
from
ecac9c5 to
1cee0f1
Compare
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two issues:
Since
BatchTaskUpdateRequestrequest has more specific URI pattern than theTaskUpdateRequest(/task/(.*)+/batchvs/task/(.*)+), we need to match batch request first otherwise all requests will be matched with normalTaskUpdateRequest.whether the last node of the plan is PartitionedOutputNode can't guarantee the query has shuffle stage, for example a plan with TableWriteNode can also have a PartitionedOutputNode to distribute the metadata to coordinator. Changed the check to see if
serializedShuffleWriteInfois null to tell whether it's a shuffle query or not.