Skip to content

[native] Minor changes in PrestoTask. #18760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Dec 3, 2022
Merged

[native] Minor changes in PrestoTask. #18760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/PrestoTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ protocol::TaskStatus PrestoTask::updateStatusLocked() {
VELOX_CHECK_NOT_NULL(task, "task is null when updating status")
const auto taskStats = task->taskStats();

// Presto has a Driver per split. when splits represent partitions
// Presto has a Driver per split. When splits represent partitions
// of data, there is a queue of them per Task. We represent
// processed/queued splits as Drivers for Presto.
info.taskStatus.queuedPartitionedDrivers = taskStats.numQueuedSplits;
Expand Down
5 changes: 2 additions & 3 deletions presto-native-execution/presto_cpp/main/types/PrestoTaskId.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* limitations under the License.
*/
#pragma once
#include <stdexcept>
#include <folly/Conv.h>
#include <string>

namespace facebook::presto {
Expand Down Expand Up @@ -61,8 +61,7 @@ class PrestoTaskId {
}

int parseInt(const std::string& taskId, int start, int end) {
auto string = taskId.substr(start, end - start);
return atoi(string.c_str());
return folly::to<int>(taskId.substr(start, end - start));
}

std::string queryId_;
Expand Down