Fix Disagg Coordinator task limit enforcement#18732
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Dec 8, 2022
Merged
Fix Disagg Coordinator task limit enforcement#18732tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
swapsmagic
force-pushed
the
disagg_cluster_query_tracker
branch
5 times, most recently
from
77da0a1 to
b508bb5
Compare
Contributor
|
@bot kick off tests |
ajaygeorge
approved these changes
Dec 3, 2022
Contributor
ajaygeorge
left a comment
ajaygeorge
left a comment
There was a problem hiding this comment.
LGTM % some comments.
presto-main/src/main/java/com/facebook/presto/resourcemanager/ResourceManagerClient.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/resourcemanager/ClusterQueryTrackerService.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/QueryTracker.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/SqlQueryManager.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/QueryTracker.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
please rename this as clusterQueryTrackerService for clarity.
Contributor
There was a problem hiding this comment.
Can you double check if the code changes are pushed. I still see the old naming of queryTrackerService
presto-main/src/test/java/com/facebook/presto/execution/TestQueryTrackerHighTaskCountKill.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/execution/TestQueryTrackerHighTaskCountKill.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/execution/TestQueryTrackerHighTaskCountKill.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/facebook/presto/resourcemanager/TestResourceManagerClusterStateProvider.java
Outdated
Show resolved
Hide resolved
swapsmagic
force-pushed
the
disagg_cluster_query_tracker
branch
from
b508bb5 to
fb6b432
Compare
ajaygeorge
approved these changes
Dec 6, 2022
Contributor
ajaygeorge
left a comment
ajaygeorge
left a comment
There was a problem hiding this comment.
LGTM % one more var rename.
For Disagg Coodinator, each coordinator is doing it's own task limit enforcement and ended up runnig lot more tasks on the cluster than configured. With this change, fixing the behavior so each coordinator get global running task count and then enforce the limit and kill queries which using tasks larger that configured limit.
swapsmagic
force-pushed
the
disagg_cluster_query_tracker
branch
from
fb6b432 to
d31317f
Compare
tdcmeehan
approved these changes
Dec 8, 2022
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Disagg Coodinator, each coordinator is doing it's own task limit enforcement and ended up runnig lot more tasks on the cluster than configured. With this change, fixing the behavior so each coordinator get global running task count and then enforce the limit and kill queries which using tasks larger that configured limit.
Test plan - unit tests