Created s3select package for presto-hive#18730
Merged
pettyjamesm merged 1 commit intoprestodb:masterfrom Dec 5, 2022
Merged
Conversation
|
|
Author
|
@pettyjamesm would you please review? |
Contributor
|
@dnanuti Please clean up the commit message to rewrite it in imperative form. Since this doesn't require a release note you can remove the Release note section as well. |
ajaygeorge
approved these changes
Dec 2, 2022
Contributor
ajaygeorge
left a comment
ajaygeorge
left a comment
There was a problem hiding this comment.
LGTM % commit message
pettyjamesm
approved these changes
Dec 5, 2022
Contributor
pettyjamesm
left a comment
pettyjamesm
left a comment
There was a problem hiding this comment.
+1 for rewording the commit title and message to imperative tone, otherwise LGTM.
Refactored S3Select related classes in their own package.
dnanuti
force-pushed
the
s3select-package-refactoring
branch
from
8ee044d to
425ddf3
Compare
Author
Updated, thanks! |
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored S3Select related classes in own package
Test plan - These changes do not bring additional behavior. Existing tests are covering this. Ran existing unit tests.
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.