Skip to content

[native] Fix gitattributes#18686

Merged
mshang816 merged 1 commit intoprestodb:masterfrom
bigfootjon:fix-gitattributes
Dec 1, 2022
Merged

[native] Fix gitattributes#18686
mshang816 merged 1 commit intoprestodb:masterfrom
bigfootjon:fix-gitattributes

Conversation

@bigfootjon
Copy link
Contributor

@bigfootjon bigfootjon commented Nov 15, 2022

This is causing problems when importing these commits to a Meta internal repo.

These files are not actually binary (despite being marked as -diff) but they are automatically generated (so -merge is correct) so this should be a no-op.

These files seem reasonably stable so I'm reasonably confident this is a no-op for OSS, it just affects Meta internals

@bigfootjon bigfootjon requested a review from a team as a code owner November 15, 2022 16:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bigfootjon / name: Jon Janzen (a6ec22b)

@v-jizhang
Copy link
Contributor

@bot kick off tests

Copy link
Contributor

@ajaygeorge ajaygeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigfootjon
Copy link
Contributor Author

@mshang816 would you mind reviewing?

Copy link
Contributor

@mshang816 mshang816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshang816 mshang816 merged commit ef40144 into prestodb:master Dec 1, 2022
@bigfootjon bigfootjon deleted the fix-gitattributes branch December 1, 2022 17:38
@wanglinsong wanglinsong mentioned this pull request Jan 12, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants