Adding support of MAP_REMOVE_NULL_VALUES for Presto#18675
Adding support of MAP_REMOVE_NULL_VALUES for Presto#18675kaikalur merged 1 commit intoprestodb:masterfrom
Conversation
|
@bot kick off tests |
|
Maybe call it MAP_REMOVE_NULL_VALUES? Not sure. Also add documentation |
I think MAP_REMOVE_NULLS also works given keys can't be null. Also users can always refer to documentation if they have doubts. Let me add documentation. |
ab98a21 to
68c35c6
Compare
|
Documentation added. |
No we should be explicit as far as possible users should understand without any other knowledge. So I say call it MAP_REMOVE_NULL_VALUES |
OK |
30c6827 to
0842bc0
Compare
...n/src/test/java/com/facebook/presto/operator/scalar/sql/TestMapRemoveNullValuesFunction.java
Outdated
Show resolved
Hide resolved
5c7d8c8 to
d0639aa
Compare
|
Can we merge this one? |
Adding support of
MAP_REMOVE_NULL_VALUESfor Presto.map_remove_null_values(map(K, V)) -> map(K, V)
Test plan
Added unit tests.
Build successfully using the following terminal command
mvn -Dtest=TestMapRemoveNullValuesFunction test