Skip to content

Support STRPOS pushdown to Pinot; Fix missing configuration property pinot.query-options error#18566

Merged
highker merged 1 commit intoprestodb:masterfrom
nizarhejazi:pinot_pushdown_strpos
Oct 31, 2022
Merged

Support STRPOS pushdown to Pinot; Fix missing configuration property pinot.query-options error#18566
highker merged 1 commit intoprestodb:masterfrom
nizarhejazi:pinot_pushdown_strpos

Conversation

@nizarhejazi
Copy link
Contributor

@nizarhejazi nizarhejazi commented Oct 26, 2022

  • Fix the following error when pinot.query-options is missing:
    Invalid configuration property pinot.query-options: may not be null (for class com.facebook.presto.pinot.PinotConfig.queryOptions)
  • Support STRPOS filter predicates pushdown to Pinot

Test plan

  • Added unit test
  • Tested against Pinot DEV env
== RELEASE NOTES ==

Pinot Changes
* Add pushdown support for ``STRPOS`` function.

@nizarhejazi nizarhejazi requested a review from a team as a code owner October 26, 2022 21:26
@xiangfu0
Copy link
Contributor

lgtm, cc: @highker

@highker highker self-requested a review October 30, 2022 22:57
@highker highker self-assigned this Oct 31, 2022
@nizarhejazi nizarhejazi force-pushed the pinot_pushdown_strpos branch from 31a01d7 to 6b05143 Compare October 31, 2022 15:49
@highker highker merged commit 816187a into prestodb:master Oct 31, 2022
@wanglinsong wanglinsong mentioned this pull request Jan 12, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants