Skip to content

[TopNOperator-Spilling] [Part-2] Extract GroupedTopNBuilder interface #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shrinidhijoshi wants to merge 2 commits into from
Closed

[TopNOperator-Spilling] [Part-2] Extract GroupedTopNBuilder interface #18399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab875f
[TopNOperator-Spilling] [Part1] Move GroupByHash management inside Gr…
shrinidhijoshi Sep 25, 2022
6ba4711
[PrestoOnSpark] Extract interface from GroupedTopNBuilder
shrinidhijoshi Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/execution/TaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public class TaskManagerConfig
private int maxWorkerThreads = Runtime.getRuntime().availableProcessors() * 2;
private Integer minDrivers;
private Integer initialSplitsPerNode;
private int minDriversPerTask = 3;
private int minDriversPerTask = 1;
private int maxDriversPerTask = Integer.MAX_VALUE;
private int maxTasksPerStage = Integer.MAX_VALUE;
private Duration splitConcurrencyAdjustmentInterval = new Duration(100, TimeUnit.MILLISECONDS);
Expand Down
7 changes: 6 additions & 1 deletion presto-main/src/main/java/com/facebook/presto/execution/executor/TaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,10 @@ public TaskExecutor(
checkArgument(interruptSplitInterval.getValue(SECONDS) >= 1.0, "interruptSplitInterval must be at least 1 second");

// we manage thread pool size directly, so create an unlimited pool
guaranteedNumberOfDriversPerTask = 1;
maximumNumberOfDriversPerTask = 1;
runnerThreads = 1;
minDrivers = 1;
this.executor = newCachedThreadPool(threadsNamed("task-processor-%s"));
this.executorMBean = new ThreadPoolExecutorMBean((ThreadPoolExecutor) executor);
this.runnerThreads = runnerThreads;
Expand Down Expand Up @@ -300,8 +304,9 @@ public TaskExecutor(
public synchronized void start()
{
checkState(!closed, "TaskExecutor is closed");
for (int i = 0; i < runnerThreads; i++) {
for (int i = 0; i < 1; i++) {
addRunnerThread();
log.info("Adding new runner thread");
}
if (interruptRunawaySplitsTimeout != null) {
long interval = (long) interruptSplitInterval.getValue(SECONDS);
Expand Down
Loading