Query failing with exceed local memory does not free memory correctly#17984
Merged
highker merged 1 commit intoprestodb:masterfrom Jul 5, 2022
Merged
Query failing with exceed local memory does not free memory correctly#17984highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
swapsmagic
force-pushed
the
memory_pool_leak
branch
2 times, most recently
from
dd8dc8d to
a51934f
Compare
Query with HashBuildOperator, if fails with exceed local memory doesn't free memory for the operator. This leads to general pool keeping the memory for it and makes the amount of memory not usable by other running queries. Reason for the leak, we reserve the memory and then do memory constraint check. And if query fails due to memory constraint, we don't free the reserved memory. We changing the order so first do memory constraint check to address it.
swapsmagic
force-pushed
the
memory_pool_leak
branch
from
a51934f to
4ae01e7
Compare
swapsmagic
changed the title
highker
approved these changes
Jul 5, 2022
tdcmeehan
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query with HashBuildOperator, if fails with exceed local memory doesn't free memory for the operator.
This leads to general pool keeping the memory for it and makes the amount of memory not usable by other
running queries.
Reason for the leak, we reserve the memory and then do memory constraint check. And if query fails due to memory
constraint, we don't free the reserved memory. We changing the order so first do memory constraint check to address it.
Test plan - Unit test, HiveQueryRunner test locally