Add parquet ecryption functionality into presto#17881
Merged
zhenxiao merged 1 commit intoprestodb:masterfrom Jun 16, 2022
Merged
Add parquet ecryption functionality into presto#17881zhenxiao merged 1 commit intoprestodb:masterfrom
zhenxiao merged 1 commit intoprestodb:masterfrom
Conversation
Co-authored-by: ggershinsky <ggershinsky@users.noreply.github.com> Summary: This is to port parquet-mr decryption apache/parquet-java@65b95fb
057eee3 to
7bf6a2b
Compare
Collaborator
Author
|
This is the PR from old PR #17791. This PR resolved the conflict with HudiParquetPageSource manually. For all other changes, it was just 'git cherry-pick' without any conflict. The path to get to this PR is: #17479 -> #17728 -> #17791 -> #17881 (this PR). If you want to find out all the review comments, please read all the PRs' comments. |
zhenxiao
approved these changes
Jun 15, 2022
Collaborator
zhenxiao
left a comment
There was a problem hiding this comment.
nice work, @shangxinli
Collaborator
|
@kewang1024 @beinan this PR looks good. |
Collaborator
|
based on approvals in #17791, I am merging this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: ggershinsky ggershinsky@users.noreply.github.com
Summary: This is to port parquet-mr decryption functionality. The main commits in parquet-mr for encryption/decryption are apache/parquet-java@65b95fb and several other fixes. This change only port the decryption only.
Test plan - (Please fill in how you tested your changes)
This feature was tested in the Uber environment and then rolled out to production for 2+ years.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.