Use REQUIRED repetition level for MAP keys in parquet writer#17879
Merged
zhenxiao merged 3 commits intoprestodb:masterfrom Jun 16, 2022
Merged
Use REQUIRED repetition level for MAP keys in parquet writer#17879zhenxiao merged 3 commits intoprestodb:masterfrom
zhenxiao merged 3 commits intoprestodb:masterfrom
Conversation
cherry-pick of trinodb/trino@f094c62 Co-Authored-By: Raunaq Morarka <raunaqmorarka@gmail.com>
As per parquet spec, MAP key should be REQUIRED cherry-pick of trinodb/trino@3247bd2 Co-Authored-By: Raunaq Morarka <raunaqmorarka@gmail.com>
yingsu00
approved these changes
Jun 15, 2022
Contributor
yingsu00
left a comment
yingsu00
left a comment
There was a problem hiding this comment.
LGTM, but I think commit 1 and 2 should be squashed into 1.
Collaborator
Author
|
oh, @yingsu00 I did not read your comment, get it merged. Will be more careful next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - TestParquetSchemaConverter, TestParquetReader