Fix bounds check in MultiChannelGroupByHash and BigintGroupByHash#17834
Merged
highker merged 1 commit intoprestodb:masterfrom Aug 3, 2022
Merged
Fix bounds check in MultiChannelGroupByHash and BigintGroupByHash#17834highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
v-jizhang
force-pushed
the
fix-bounds-check
branch
from
16bcfea to
2ab5135
Compare
v-jizhang
force-pushed
the
fix-bounds-check
branch
from
2ab5135 to
61639d6
Compare
ajaygeorge
reviewed
Jun 5, 2022
Contributor
ajaygeorge
left a comment
ajaygeorge
left a comment
There was a problem hiding this comment.
Changes look good.
Can we add a test case if possible to highlight the off by one issue we are fixing.
Cherry-pick of trinodb/trino#12597 There's an off-by-one error in the check that can cause a failure when the page is empty. Co-authored-by: Karol Sobczak <napewnotrafi@gmail.com>
v-jizhang
force-pushed
the
fix-bounds-check
branch
from
49c9c82 to
183608c
Compare
Contributor
Author
Added a test. Thanks. |
highker
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#12597
There's an off-by-one error in the check that
can cause a failure when the page is empty
Co-authored-by: Karol Sobczak napewnotrafi@gmail.com