[Pinot Connector] Enable pinot grpc by default#17819
Merged
highker merged 1 commit intoprestodb:masterfrom Jun 24, 2022
Merged
Conversation
ajaygeorge
approved these changes
Jun 5, 2022
Contributor
Author
|
cc: @highker |
highker
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinot side has by default turn on grpc query endpoint, so it makes sense to turn on grpc endpoint by default as well.
Note that this won't impact existing users who don't turn on grpc, the fallback behavior to netty query endpoint happens automatically.