Introducing LocalMode to DistributedClusterStats #17817
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jun 23, 2022
Merged
Introducing LocalMode to DistributedClusterStats #17817tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
|
Contributor
|
swapsmagic
requested changes
Jun 1, 2022
...s/src/test/java/com/facebook/presto/resourcemanager/TestDistributedClusterStatsResource.java
Outdated
Show resolved
Hide resolved
...s/src/test/java/com/facebook/presto/resourcemanager/TestDistributedClusterStatsResource.java
Outdated
Show resolved
Hide resolved
cd9ad16 to
c895933
Compare
c895933 to
ccecd77
Compare
swapsmagic
approved these changes
Jun 2, 2022
Contributor
swapsmagic
left a comment
There was a problem hiding this comment.
Update release note /v1/cluster with backquote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description - Adding local mode to the existing cluster endpoint so that it can be easier to find out which queries are running on the local coordinator instead of the whole cluster when running disaggregated coordinator mode. Figuring out local information can help with debugging purposes.
Test plan - Created a unit test that runs and queues multiple queries on different coordinators. The test checks that if local mode is enabled when requesting statistics from a cluster, the amount of queries that are running locally on that specific coordinator are returned instead of the amount of queries running on the whole cluster.